Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919429
Hans de Goede <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Hans de Goede <[email protected]> --- Hi, Full review done: Good: - rpmlint checks return: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: - Just like with nmon, no COPYING.txt with the gpl text is included, please mail upstream asking them to fix this for the next release - I don't see the need to remove the .png and empty messages.po, please remove this from %prep - The %{_libdir}/gimp/2.0/plug-ins dir is owned by the gimp, so the %files section should not own it. Naming the dir in %files will own the dir and all files under it. Instead add the full plugin path to %files Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D7L7PtKSEE&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
