Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919429

--- Comment #3 from Palle Ravn <[email protected]> ---
(In reply to comment #2)
> Needs work:
> - Just like with nmon, no COPYING.txt with the gpl text is included, please
> mail upstream asking them to fix this for the next release

Doing that now.

> - I don't see the need to remove the .png and empty messages.po, please
> remove this from %prep

Included again.

> - The %{_libdir}/gimp/2.0/plug-ins dir is owned by the gimp, so the %files
> section should not own it. Naming the dir in %files will own the dir and all
> files under it. Instead add the full plugin path to %files

dbp appended to ../2.0/plug-ins/

New files:
Spec URL: http://dbp.zom.dk/gimp-dbp.spec
SRPM URL: http://dbp.zom.dk/gimp-dbp-1.1.9-2.fc18.src.rpm

rpmlint:
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/gui.cc
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/gui.h
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/op.cc
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/op.h
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/gimpCall.h
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/dbp.cc
gimp-dbp-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/dbp-1.1.9/gimpCall.cc
3 packages and 1 specfiles checked; 7 errors, 0 warnings.


koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=5135932

Regards Palle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=exCpJKurye&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to