Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927269

--- Comment #3 from Michal Schmidt <[email protected]> ---
> Version: 0.5.0
> Release: 0%{?dist}

Glamor 0.5.0 was released last year. You are packaging a more recent git
snapshot, so the versioning must follow the rules for snapshots:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

> # source tarball has to be created from git (not ftp/http tar archive) at :
> # http://cgit.freedesktop.org/xorg/driver/glamor/

The instructions should be more specific to allow anyone to recreate the same
tarball. See:
https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

> %description
> glamor provide xorg-x11 acceleration using the OpenGL driver.

s/provide/provides/ ?

> find $RPM_BUILD_ROOT -type f -name '*.la' | xargs rm -f -- || :

Looks like you could simplify the command if you just used find's "-delete"
action.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4ZsLvgftfd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to