Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269
--- Comment #7 from Michal Schmidt <[email protected]> --- (In reply to comment #6) > Should i update the changelog even now as package is not accepted yet. It > would leave a trace of all my mistake making package thought ;) Indeed it would and it's customary to do that. However, I won't insist on having multiple changelog entries during this review. At the very least, please keep the version-release of your %changelog entry consistent with the actual values, OK? (In the latest spec you already do that, good!). The SRPM now builds successfully, which allowed me to run rpmlint on it. Some issues to fix (or explain why they're not a problem): - xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit@GLIBC_2.2.5 This is something to consider upstream. - xorg-x11-glamor.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libglamor.so - xorg-x11-glamor.x86_64: E: library-without-ldconfig-postin /usr/lib64/libglamor.so.0.0.0 See: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries - There's a whole bunch of warnings like: xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 serverClient If these are expected, please explain why. Also please use %global instead of %define. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ik1wtp2tTa&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
