https://bugzilla.redhat.com/show_bug.cgi?id=990544

Christopher Meng <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Christopher Meng <[email protected]> ---
1. Can you tell me why removing

rm -f %{buildroot}%{_exec_prefix}/%{_lib}/libventrilo3.so

but not moving them to -devel?

2. Have you tried %configure --disable-static to avoid generating static libs?

3. You should use %{_libdir} instead of %{_exec_prefix}/%{_lib}

4. %{_datarootdir} can be %{_datadir} ;)

5. Package ships 2 license file, but you only include one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6ONaHR8X7T&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to