https://bugzilla.redhat.com/show_bug.cgi?id=990544
--- Comment #2 from Palle Ravn <[email protected]> --- (In reply to Christopher Meng from comment #1) > 1. Can you tell me why removing > > rm -f %{buildroot}%{_exec_prefix}/%{_lib}/libventrilo3.so > > but not moving them to -devel? I was unaware of the devel part of packaging, as I never had the need. I have added a -devel package including .a .h and .so files. > 2. Have you tried %configure --disable-static to avoid generating static > libs? Yes, and it did not change the static rpath. > 3. You should use %{_libdir} instead of %{_exec_prefix}/%{_lib} Fixed. > 4. %{_datarootdir} can be %{_datadir} ;) Works better with vim highlighting, thanks :D > 5. Package ships 2 license file, but you only include one. Both included. All files are at www.zom.dk/mangler, note that I have not changed the revision number. I will of course notify upstream about the wrong fsf address in one of the source files. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pO9IF8N44F&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
