https://bugzilla.redhat.com/show_bug.cgi?id=1000334
--- Comment #3 from Mamoru TASAKA <[email protected]> --- Some initial comments: * Software Collection macros - I don't know well about the current status of SCL, however it you want to add SCL macros, please follow https://fedoraproject.org/wiki/Packaging:Guidelines#Software_Collection_Macros (especially the sentence beginning whth "Packages who choose....") ? Unknown macros - Would you explain how %git_hash macro is used? (Also see below) * Licensing - The following page https://raw.github.com/grosser/single_test/master/Readme.md says this is under MIT. At least please include the above license text in the binary rpm and modify License tag. * Using %gem_install - %gem_install is available on Fedora 18 and above (so you can change to %if 0%{?fedora} >= 18 ) * %check - > Just quick note: spec file does not contain %check section, > because tests use bundler and therefore are not so much useful for us. Well, so would you explain why "BR: rubygem-rspec" exists? (By the way. please use rubygem(rspec) instead of rubygem-rspec) Note that git source https://github.com/grosser/single_test.git contains spec/ directory and it seems you can do some tests via $ rspec spec/ using git source. It is recommended that you package test files under spec/ directory from git source and add %check section, do some tests there (or still bundler is needed for rspec test suite?) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9gpd0HNyvD&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
