https://bugzilla.redhat.com/show_bug.cgi?id=1000334

Miroslav Suchý <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[email protected] |
                   |project.org                 |



--- Comment #5 from Miroslav Suchý <[email protected]> ---
> * Software Collection macros
added that comment

> %git_hash macro
This was left over (see below). Removed.

> * Licensing
Good catch. I missed this. Fixed. I however decided to not include separate
license file as I am not sure what to put in first line of MIT-LICENSE. Filed:
https://github.com/grosser/single_test/issues/12

> * Using %gem_install
Fixed.

> * %check
Well I tried to package that git archive and include it as SOURCE1 (from this
try-and-error comes that %git_hash macro where I stored git hash from which I
made tar.gz).
I tried to run
  rspec spec/
But what cause problems is:
  bundle exec rspec
And I'm not really sure if seding it to s/bundle exec rspec/rspec/ is correct
way. I would rather avoid that as the semantics can be different.

> * rpmlint
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AGHg3U2teL&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to