https://bugzilla.redhat.com/show_bug.cgi?id=915913

Lubomir Rintel <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #2 from Lubomir Rintel <[email protected]> ---
* Package named properly
- Latest version not used, probably fine
- License text is not present
- The SPEC file in SRPM and one linked to differ (see below)
- SPEC file clean and legible
* Require list sane
* Provides sane
* Filelist sane
- Debuginfo package empty
* Owns all files it should own
* Builds fine in mock

0.) You refer to license files in a comment, but don't ship any documentation

Please clarify which package are livense files in, and possibly ask upstream to
include full license text.

1.) Please make sure the package uses correct Source tag, your two SPEC files
differ:

-Source0:
http://download.qt-project.org/archive/qt/5.0/%{version}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz
+Source0:
http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz

2.) Please disable generation of debuginfo package (or turn it noarch -- qml
files look like they shoul belong to datadir instead of libdir)

3.) Please consider using more useful description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bWQHfuLTwU&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to