Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=587438 --- Comment #6 from Michael Stahnke <[email protected]> 2010-05-24 11:57:30 EDT --- I have fixed the comments unrelated to the test. I am trying decide if patching simply for tests is a good idea. In general, I'd rather not carry patches against upstream if I can help it. I can contact upstream about the tests and see if they can either fix them or explain to me the proper method for running them. Very thorough and good review thus far. I do appreciate it. http://stahnma.fedorapeople.org/reviews/rubygem-snmp-1.0.2-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
