Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=587438 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Mamoru Tasaka <[email protected]> 2010-05-24 14:23:14 EDT --- Well, I think that if the provided tests fail, at least - the cause should be examined (especially the cause is because the failed test is badly written or the main program itself is broken) - the fact should be noticed to the upstream that the provided test fails And if patch is available, submitting the patch to the upstream will be appreciated (by the upstream). By the way one other thing. * Consistent macros usage - If you want to use %{__sed} style, please use this style everywhere if this is available for consistency (like %{__mkdir}, %{__rm}, %{__mv}). ----------------------------------------------------------------- This package (rubygem-snmp) is APPROVED by mtasaka ----------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
