https://bugzilla.redhat.com/show_bug.cgi?id=1034341
--- Comment #18 from Simon Farnsworth <[email protected]> --- (In reply to Dan Fruehauf from comment #15) > Simon, things look already pretty spotless, especially if Michael is > reviewing your stuff :) > > I wonder though why you wouldn't just include in %files: > %{python2_sitearch}/gi/overrides/* > > Can save a few good lines and make things more consistent and less sensitive > to upstream changes (it's even recommended - > https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics) I'll do that once Peter's done his review. Peter, I'm going to change %files from: %files %doc AUTHORS COPYING ChangeLog NEWS README %{python2_sitearch}/gi/overrides/GstPbutils.py %{python2_sitearch}/gi/overrides/GstPbutils.pyc %{python2_sitearch}/gi/overrides/GstPbutils.pyo %{python2_sitearch}/gi/overrides/Gst.py %{python2_sitearch}/gi/overrides/Gst.pyc %{python2_sitearch}/gi/overrides/Gst.pyo %{python2_sitearch}/gi/overrides/_gi_gst.so to %files %doc AUTHORS COPYING ChangeLog NEWS README %{python2_sitearch}/gi/overrides/* after your review, unless you recommend that I don't. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
