https://bugzilla.redhat.com/show_bug.cgi?id=1034341
--- Comment #19 from Michael Schwendt <[email protected]> --- Hmm, I haven't had a look at the spec file before... > Name: gstreamer1-python Since it's a Python module to make it easier to use GStreamer within Python, it should following the %parent-%child naming guidelines for Python add-on packages, shouldn't it? Name: python-gstreamer1 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 > Requires: gstreamer1 >= 1.2.0 It already depends on the libstreamer SONAME automatically, and a comment should explain why this explicit dependency with minimum version is needed: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Since the dep should be arch-specific, add %{?_isa} to it: gstreamer1%{?_isa} [...] Using wildcards in %files lists can be convenient, but may be more fragile. In this case, %{python2_sitearch}/gi/overrides/* includes "anything" and could silently (and without causing a build failure) drop parts of the API and break dependencies, whereas %{python2_sitearch}/gi/overrides/GstPbutils.py* %{python2_sitearch}/gi/overrides/Gst.py* %{python2_sitearch}/gi/overrides/_gi_gst.so would be a safer compromise. It would ensure that those files must be available. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
