https://bugzilla.redhat.com/show_bug.cgi?id=1051665
Rahul Sundaram <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Rahul Sundaram <[email protected]> --- Cursory first look: * Is there any particular reason the conf file is not part of upstream? https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment * I would use %make_install instead of make install DESTDIR=$RPM_BUILD_ROOT * Might consider using %{buildroot} for consistency Why is this noreplace? if it is not supposed to be edited by users, should it be in /etc? %config(noreplace) %{_sysconfdir}/sysconfig/vdr-plugins.d/skinnopacity.conf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
