https://bugzilla.redhat.com/show_bug.cgi?id=1051665



--- Comment #8 from MartinKG <[email protected]> ---
(In reply to Rahul Sundaram from comment #6)
> rpmlint complains about the use of macro in the changelog.  so you might
> want to drop % or use %%

done
> license according to the README is GPLv2+ and not GPL+

done
> /etc/vdr/themes/ doesn't seem to be appropriate location for themes or any
> non user modifiable configuration files.

changed in %install section, as it has already been made in both vdr repo
packets.

vdr-skinsoppalusikka.spec: install -pm 644 themes/*.theme
$RPM_BUILD_ROOT%{vdr_vardir}/themes/
vdr-skinenigmang.spec: install -pm 644 themes/*.theme
$RPM_BUILD_ROOT%{vdr_vardir}/themes

%install
# make install would install the themes under /etc, let's not use that
make install-lib install-i18n install-icons DESTDIR=$RPM_BUILD_ROOT
# install the themes to the custom location used in Fedora
install -dm 755 $RPM_BUILD_ROOT%{vdr_vardir}/themes
install -dm 755 $RPM_BUILD_ROOT%{vdr_vardir}/plugins/skinnopacity/themeconfigs
install -pm 644 themes/*.theme $RPM_BUILD_ROOT%{vdr_vardir}/themes/
install -pm 644 conf/theme-*
$RPM_BUILD_ROOT%{vdr_vardir}/plugins/skinnopacity/themeconfigs/

https://dl.dropboxusercontent.com/s/ta395xq9iv9hary/vdr-skinnopacity.spec
https://dl.dropboxusercontent.com/s/ibzot9jb63cgc1p/vdr-skinnopacity-1.0.3-5.0b29805.fc20.src.rpm

%changelog
* Wed Jan 15 2014 Martin Gansser <[email protected]> - 1.0.3-5.0b29805
- removed macro in changelog
- corrected license type to GPLv2+
- installed themes and themeconfigs to the custom location used in Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to