https://bugzilla.redhat.com/show_bug.cgi?id=1063047



--- Comment #3 from Mo Morsi <[email protected]> ---
Hey Nitesh some more comments:

- Please rename the spec to 'rubygem-em-websocket-client.spec' so fedora-review
will pick it up

- The rspec command in the %check section should be "rspec -Ilib spec"

- The .document and .rspec %files should be rm'd or %excluded

- Marking files under "%files doc" as %doc is a bit redundant, though don't
believe this is a blocker

- again "Updated as per the comments" in your changelog entry is a bit
ambiguous, perhaps some like "updated to comply w/ Fedora guidelines" would be
more direct

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to