https://bugzilla.redhat.com/show_bug.cgi?id=1094864
Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Remi Collet <[email protected]> --- Quick notes: - unused macro php_apiver - unneeded default value php_extdir (if really you want to provides default value for it, you also need to provide default one for php_inidir) - please run upstream provided test suite - please install doc in %pecl_docdir (so "pecl list-files xmldiff" will be ok, I know this is only explicitly written in Guildelines for pear package...) - prefix ini file with numeric value in rawhide %if 0%{?fedora} < 21 # After dom %global ini_name %{pecl_name}.ini %else # After 20-dom %global ini_name 40-%{pecl_name}.ini %endif - filtering private is no more needed in f20+ (and rhel7) - why don't you provide the -devel sub package ? (with the installed header, and perhaps the upstream test suite... useful as documentation) - requires Requires php-dom%{_isa} and php-libxml%{?_isa} instead of php-xml (from source code): xmldiff.cpp: ZEND_MOD_REQUIRED("dom") xmldiff.cpp: ZEND_MOD_REQUIRED("libxml") -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
