Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569671

--- Comment #10 from Martin Gieseking <[email protected]> 2010-06-17 
15:25:43 EDT ---
Here are a couple of quick comments:

- in the first line, replace %define with %global

- according to the source file headers, the license is GPLv2+, not GPLv2

- I suggest to use the default %description for the devel package:
  The %{name}-devel package contains libraries and header files for
  developing applications that use %{name}.

- remove the duplicate %defattr line in %files devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to