https://bugzilla.redhat.com/show_bug.cgi?id=1111294
--- Comment #5 from Dominik 'Rathann' Mierzejewski <[email protected]> --- Sorry, I was quite busy lately. Some comments while fedora-review is processing: # Rename licence file... mv licence.txt license.txt Why? The guidelines say the spec file must be written in American English, but that doesn't mean the filenames must be, too. # Desktop file, icon echo "Icon=engrid.png" >> engrid.desktop sed -i 's/Education;/Science;/' engrid.desktop The two lines above can be done with appropriate options in desktop-file-install invocation, please use them (--set-icon and --add-category/--remove-category). Also, the Icon= option should be set to engrid, not engrid.png, as required by desktop file guidelines. Please also try adding appdata, as the guideline has been approved recently (http://people.freedesktop.org/~hughsient/appdata/), Out of curiosity, are there any consumers of that shared library apart from this package? I don't see a -devel subpackage... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
