https://bugzilla.redhat.com/show_bug.cgi?id=1111294
--- Comment #7 from Sandro Mani <[email protected]> --- Thank you for the careful review. Concerning the icon, the reason I include it as a separate source is because the original icon is not a standard sized (46x51). I suppose I could BR imagemagick and resize the image in %prep, I feel it more robust to include it as a separate source but am fine with either method. Concerning other users of the shared library: none that I know of for sure at the moment, OpenFOAM might be one. But in any case I'd rather keep the upstream build scripts as far as possible. Concerning the shared-lib-calls-exit and license files, upstream report is here: https://github.com/enGits/engrid/issues/47 Spec URL: http://smani.fedorapeople.org/review/engrid.spec SRPM URL: http://smani.fedorapeople.org/review/engrid-1.4.0-2.gite6d55f5.fc21.src.rpm %changelog * Wed Jul 30 2014 Sandro Mani <[email protected]> - 1.4.0-2.gite6d55f5 - Don't rename license file - Use desktop-file-install to set icon and fix category - Add doc subpackage - Add blender subpackage - Update build patch to also link against vtk libraries, and not QtNetwork -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
