https://bugzilla.redhat.com/show_bug.cgi?id=1134835

Christopher Meng <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |505154 (FE-SCITECH)



--- Comment #5 from Christopher Meng <[email protected]> ---
V3 is not enough, v8 might be good ;)

Something unsatisfied:

1. Drop BR gcc-c++.

2. Drop rm -rf %{buildroot}

3. This is superfluous:

%{_exec_prefix}/lib/kissplice/*

This package is not noarch packages(arch independant), we put libs on X86_64 at
%{_libdir} aka /usr/lib64.

If your package installs programs to /usr/lib, I think it's wrong, at least
should be /usr/bin.

I haven't taken deep look on those files(only from koji), can you tell us what
are these?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to