https://bugzilla.redhat.com/show_bug.cgi?id=1172719
--- Comment #3 from David Howells <[email protected]> --- (In reply to Michael Schwendt from comment #2) > Further, isl.pc relinks with -lgmp, which is not necessary when linking > shared. True, but it also shouldn't hurt. > And isl.pc doesn't specify a pkgconfig dependency on gmp/gmp-devel, because > that one does not include any pkgconfig file. I'm not sure what I can do about that without modifying the gmp package. > > -rwxr-xr-x /usr/lib64/libisl.la > > These libtool archives are covered here: > https://fedoraproject.org/wiki/Packaging: > Guidelines#Packaging_Static_Libraries That shouldn't be there - I have a line that supposedly removes that in the spec file and I don't see it when I build the RPMs. > > %install > > make install ... > > Use %makeinstall: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_. > 25makeinstall_macro_should_not_be_used Why? Did you mean %make_install instead? Note that it doesn't seem like this should be necessary. Anyway, revised: Spec URL: http://people.redhat.com/dhowells/isl.spec SRPM URL: http://people.redhat.com/dhowells/isl-0.14-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
