https://bugzilla.redhat.com/show_bug.cgi?id=1079090
--- Comment #36 from Mohammed Isam <[email protected]> --- (In reply to Jonathan Dieter from comment #35) > Package Review > ============== > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/fonts, > /etc/fonts/conf.d, /usr/share/fontconfig/conf.avail, > /usr/share/fontconfig, /etc/fonts > > Please add Requires: fontpackages-filesystem to the -common subpackage > I added the Requires line to the spec. I don't need to add the individual ownerships to the %files directory, do I? > [!]: Each %files section contains %defattr if rpm < 4.4 > > Note: %defattr present but not needed Not fixed. Honestly I don't get it. My %files section doesn't contain any %defattr? > > [!]: License field in the package spec file matches the actual license. > > Package license and license included in tarball is GPLv3+, but, > according > to ttname.log, licenses in ttf files are all SIL OFL 1.1. Since you're > also upstream for this package, I'd recommend sticking with SIL OFL 1.1. > Added the OFL license file (actually, three files according to the OFL directions). Removed the GPL file and updated the License field in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
