https://bugzilla.redhat.com/show_bug.cgi?id=1195153

Michal Minar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Michal Minar <[email protected]> ---
My findings:
  * there's a new version of lmiwbem available (0.7.0) why not bundle it?
  * moreover lmiwbem-0.6.0-2.fc22 already exists in koji
  * lmiwbem.spec should be python-lmiwbem.spec 
    - fedora-review tool refused to run due to this
  * according to [1], Obsoletes should include a release higher than the last
available release of the old package
    - If I understand this correctly, it should be:
      Obsoletes: lmiwbem <= 0.6.0-3
  * again according to [1], Provides should be listed twice - once with
%{?_isa} macro and once without:
      Provides: lmiwbem         = %{version}-%{release}
      Provides: lmiwbem%{?_isa} = %{version}-%{release}

rpmlint findings:
  * python-lmiwbem.spec: W: invalid-url Source0:
https://github.com/phatina/lmiwbem/releases/download/python-lmiwbem-0.6.0/python-lmiwbem-0.6.0.tar.gz
HTTP Error 404: Not Found
    The value should be a valid, public HTTP, HTTPS, or FTP URL.

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to