https://bugzilla.redhat.com/show_bug.cgi?id=1195153



--- Comment #2 from Peter Hatina <[email protected]> ---
Spec URL:
https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem.spec
SRPM URL:
https://phatina.fedorapeople.org/rpms/python-lmiwbem/python-lmiwbem-0.7.0-1.fc23.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9049374

(In reply to Michal Minar from comment #1)
> My findings:
>   * there's a new version of lmiwbem available (0.7.0) why not bundle it?

OK, done.

>   * moreover lmiwbem-0.6.0-2.fc22 already exists in koji
>   * lmiwbem.spec should be python-lmiwbem.spec 
>     - fedora-review tool refused to run due to this
>   * according to [1], Obsoletes should include a release higher than the
> last available release of the old package
>     - If I understand this correctly, it should be:
>       Obsoletes: lmiwbem <= 0.6.0-3

Done.

>   * again according to [1], Provides should be listed twice - once with
> %{?_isa} macro and once without:
>       Provides: lmiwbem         = %{version}-%{release}
>       Provides: lmiwbem%{?_isa} = %{version}-%{release}

Done.

> 
> rpmlint findings:
>   * python-lmiwbem.spec: W: invalid-url Source0:
> https://github.com/phatina/lmiwbem/releases/download/python-lmiwbem-0.6.0/
> python-lmiwbem-0.6.0.tar.gz HTTP Error 404: Not Found
>     The value should be a valid, public HTTP, HTTPS, or FTP URL.

According to Github and rpmlint:  Tarball for 0.7.0 is accessible, via several
redirections.  Rpmlint dislikes this, but this is the way, how we release new
versions of lmiwbem.

> 
> [1]
> http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
> 2FReplacing_Existing_Packages

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to