https://bugzilla.redhat.com/show_bug.cgi?id=1204898

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in libntirpc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- Summary and description for -devel subpackage usually just say something
like:
Summary     : Development headers for %{name}
Description :
Development headers and auxiliary files for developing with %{name}.

- Consider using %autosetup instead of %setup + %patch.

- make %{?_smp_mflags} || make %{?_smp_mflags} || make
???

- The build system seems "suboptimal". Why does it need to be patched in spec
file, *and* then fixed up afterwards in %install?

- There are tests in the upstream tarball. Can they be run in %check?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to