https://bugzilla.redhat.com/show_bug.cgi?id=1204898
--- Comment #4 from Kaleb KEITHLEY <[email protected]> --- >> - The build system seems "suboptimal". Why does it need to be patched in >> spec file, *and* then fixed up afterwards in %install? > > 1) The patch and the fixups should eventually go away. > > 2) Obviously I can't patch the ../src/CMakeLists.txt to hard code install to > /usr/lib64 as that will break on 32-bit archs. I could create two patches and > patch accordingly on 32- and 64-bit; that seems worse IMO. > > 3) I haven't found the correct fix to the top-level CMakeLists.txt to install > the .pc file in /usr/lib{,64}/pkgconfig. Suggested fixes are welcome. > > 4) The patch changes the library from a static lib to a shlib AND changes the > install location from /bin to /lib. I could remove the change of the > installed location but I'd still have a patch and I'd still have a fixup. Or I could just remove the `make install` and install everything explicitly in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
