https://bugzilla.redhat.com/show_bug.cgi?id=1262552
--- Comment #8 from Kevin Fenzi <[email protected]> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > > $ /usr/share/doc/python2-pyhsm/Tests/run.sh > python: can't open file '/usr/share/doc/python2-pyhsm/Tests/../setup.py': > [Errno 2] No such file or directory > > It also refers to ../Lib, which is not in the package at all. Oh right. It does the tests from the source tree after build, but before install. That Lib is in the source checkout. > Some executables in the package in /usr/bin/ have /usr/bin/env python, > others have /usr/bin/python. This is kind of inelegant. Also there's bigger > chance of running a user-installed python by mistake. Changing it to > /usr/bin/python2 everywhere makes things crystal clear. I don't think that > there's an official guideline, but I think it's generally recommended. ok. I'll check with upstream and if they don't respond or the like carry a patch. > OK, please fix (or not) the two small issues pointed out above as you see > fit. Package is APPROVED. Thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
