https://bugzilla.redhat.com/show_bug.cgi?id=1274948
Miroslav Suchý <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #1 from Miroslav Suchý <[email protected]> --- Taking. Those two comments are superfluous. Just leave that one comment about license and remove those two remaining. Be consistent about spacing between section. One (or two lines) are usually used. You use 6 lines before %files and 0 lines before %prep. Additionally putting new lines randomly in spec make it hard to read (e.g before BR and Source0). New line in %description counts as space. No need to put space at the beginning of line. You are missing dot at the and of sentence in description. Please use: /etc/pki/pki-usgov-dod-cacerts as directory name. > %config(noreplace) /etc/pki/usgov_dod/cacerts/ This is not config - despite being in /etc/ which is usually for config. If you update some cert you want to overwrite it on user machine. So please omit %config(noreplace). Some certificates (e.g. DOD_CA-18-32-58468.pem) contain outdated certificates. What is the reason for including such files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
