https://bugzilla.redhat.com/show_bug.cgi?id=1274948
--- Comment #6 from Miroslav Suchý <[email protected]> --- >%global commit0 8dc419c5644fc7305f757ec571406f5b2e0a96af >%global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) It is good habit to declare macros at the very top of the file. ># This package is security sensitive, ># certs are used to authenticate military websites ># [email protected] I'm not sure if my comment about comments were clear. I would remove this, but leave the comment why the license is public domain. You are missing BuildRequires: perl needed for kcs7_split.pl While it is at the end tranistively loaded via other BR it should be there. Otherwise it looks good and once we settle on that /etc/pki path I think this can be approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
