https://bugzilla.redhat.com/show_bug.cgi?id=1271379
--- Comment #2 from Michele Baldessari <[email protected]> --- Thanks Zbigniew! (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Summary should not repeat the name. Something like this instead: > Summary: Direct execution of SQL-like queries on tabular text files ok, done > Don't gzip the man page. It will be done automatically by rpm. > Also use q-test-as-data.1.* in %files (not .gz), so there is no need to > adjust if the compression scheme ever changes. ok, done > Why 'rm -f'? The removal should not fail under any circumstances, so plain > 'rm' should be used. right, done > You have with_python3 defined, but it is not used anywhere. > > Does the program support python3? If yes, then it should run under python3. > > Independently of whether python2 or python3 is used, the shebang line should > be changed from /usr/bin/env... to /usr/bin/python2 or /usr/bin/python3. Try: > sed -i '1s/#!.*/#!%{__python2}/' FILENAME So I have added python3 support in the package, so we just need to flip the switch once python3 support lands (I made a note of which github issue tracks this in the spec file). Spec URL: http://acksyn.org/files/rpms/q-data-as-text/q-text-as-data.spec SRPM URL: http://acksyn.org/files/rpms/q-data-as-text/q-text-as-data-1.5.0-2.fc23.src.rpm Thanks again -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
