https://bugzilla.redhat.com/show_bug.cgi?id=1271379
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- Please note that this spec file will not build if with_pytohn3 is undefined (e.g. on RHEL). "%if %{?with_python3}" would expand to "%if", which is not valid. It works for Fedora though, so as far as this review goes, that's enough. "%if 0%{?with_python3}" would make more sense, and then there's no need to define with_python3 to 0, just define it to 1 in the future. + license is acceptable (GPLv3) + license file is present, %license is used + provides and requires look OK + builds and installs fine + name is ok + latest version + no scriptlets present or necessary Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
