Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620385

Martin Gieseking <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #3 from Martin Gieseking <[email protected]> 2010-08-29 
08:57:12 EDT ---
Hi Adam,

some initial comments:

- the license seems to be GPLv2+ (according to the source file headers)

- file LICENSE is missing in %doc

- The package contains the "curl" sources (in src/utils/curl). You should
remove 
  them and rely on the corresponding Fedora package instead.

- set the file permissions of the data files to 644, e.g. with
  find %{buildroot}%{_datadir}/%{name} -type f -exec chmod 0644 {} \;

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to