Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620385

--- Comment #4 from Adam Huffman <[email protected]> 2010-08-31 06:45:04 EDT 
---
Martin,

Thanks for taking a look.  New version addressing your comments is at:

http://verdurin.fedorapeople.org/reviews/BEDTools/BEDTools.spec

http://verdurin.fedorapeople.org/reviews/BEDTools/BEDTools-2.9.0-2.fc13.src.rpm

I've contacted upstream about the library bundling.  So far as I can see, it's
not actually referred to in any of the individual Makefiles.

There is an extra warning from rpmlint now, relating to the removal of the curl
directory:

BEDTools.src:32: W: rpm-buildroot-usage %prep rm -rf
%{buildroot}/src/utils/curl
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Here are the warnings for the binary packages:

BEDTools.x86_64: W: no-manual-page-for-binary complementBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary genomeCoverageBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary mergeBed
Each executable in standard binary directories should have a man page.
BEDTools.x86_64: W: no-manual-page-for-binary pairToPair
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary groupBy
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary fastaFromBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary slopBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary bedToIgv
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary overlap
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary subtractBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary bamToBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary intersectBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary maskFastaFromBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary bed12ToBed6
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary bedToBam
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary unionBedGraphs
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary sortBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary windowBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary closestBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary linksBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary shuffleBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary coverageBed
Each executable in standard binary directories should have a man page.

BEDTools.x86_64: W: no-manual-page-for-binary pairToBed
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 0 errors, 23 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to