https://bugzilla.redhat.com/show_bug.cgi?id=1294523
Simone Caronni <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Blocks|177841 (FE-NEEDSPONSOR) | Assignee|[email protected] |[email protected] --- Comment #1 from Simone Caronni <[email protected]> --- No longer blocking FE-NEEDSPONSOR. I will sponsor Vitaly. Please remove this lines, they are not needed: > # generating empty configure script > echo '#!/bin/bash' > configure > chmod +x configure > %configure It is not mandatory to have a configure script. You can use the following to pass correct CFLAGS when building: > export CFLAGS="%{optflags}" > %make_build A personal request; can you please add these two lines to the "purple-skypeweb" pacakge? > Provides: skype4pidgin = %{version}-%{release} > Obsoletes: skype4pidgin < %{version}-%{release} I've been packaging all skype4pidgin plugins for years (including libskypeweb) until now, where skypeweb is mature enough. I would like to make the transition transparent to the official Fedora packages for my users: http://negativo17.org/skype-and-skype-pidgin-plugin/ This can be removed in a few months. Please provide again the "Spec URL" and "SRPM URL" lines with the latest changes, fedora-review needs to have them when parsing packages/spec files. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
