https://bugzilla.redhat.com/show_bug.cgi?id=1294523



--- Comment #6 from Vitaly Zaitsev <[email protected]> ---
> This is ok, but please ask upstream to add all proper headers. Otherwise, 
> since this is a subset of the whole (obsolete) skype4pidgin tarball, just 
> package in the tarball only the required folders. You can use this guideline 
> if you want to proceed that way:

Yes, I'll add script which will repackage tarball.

> Just remove the "theme" at the end of this line in the files section:

Done.

> Please add some notes to the patch. I don't see why the code in the patch 
> should be removed, if there is an explanation for it, please add it to the 
> SPEC file.

This patch is no longer needed.

> There's a typo in the comment, 's/inplemented/implemented/g'.

Fixed. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to