https://bugzilla.redhat.com/show_bug.cgi?id=1364618
--- Comment #15 from Luya Tshimbalanga <[email protected]> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #14) > This still doesn't build for me. I needed the following "patch": > > sed -r -i.bak 's/#include <math.h>/#include <cmath>/' common/math/constants.h > sed -r -i.bak '/__forceinline float (abs|floor|ceil)/d' common/math/math.h > > I think it's also good to silence all warnings: -Wno-all in CXXFLAGS. > Otherwise there's just too much noise. Using those lines greatly reduce the building time. They fixed the failure as well. > > %files seems totally broken: > - .so file must be in -devel > - .so.* must be in the main package > - %{_bindir}/%{name}/* doesn't match anything > [...] Thanks for the correction. Fixed. > What about the examples that are now built? Shouldn't they be run in %check, > and packaged into -examples subpackage? -examples subpackage added now running in %check following the cmake guideline. Here is the updated files: Spec URL: https://luya.fedorapeople.org/packages/SPECS/embree.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/embree-2.10.0-5.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
