https://bugzilla.redhat.com/show_bug.cgi?id=1364618

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #20 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
In %files, change %{_libexecdir}/%{name}/* to %{_libexecdir}/%{name}/,
otherwise the directory is going to be unowned.

I don't think the tests do anything:
+ ctest -V -j12
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
Test project /builddir/build/BUILD/embree-2.10.0
Constructing a list of tests
Checking test dependency graph...
Checking test dependency graph end
No tests were found!!!
+ exit 0

You can run benchmark as a test instead.

+ package name is OKt
+ license is acceptable (ASL 2.0)
+ license is specified correctly 
+ latest version
+ builds and install OK
+ provides/requires/BR look OK
+ rpmlint is happy
+ scriptlets look OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to