https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #12 from Pavel Raiskup <prais...@redhat.com> ---
Thanks for having a look!

(In reply to Vít Ondruch from comment #11)
> 1. I consider good habit to include vim- prefix in vim plugin package name.

That's one of the notes I suggested in original review.

> 2. It is good idea to include AppData file in package, to make this plugin
> visible in Gnome Software.

TBH, I have no idea what Gnome Software is so I'm not the best
person to write the patch.  If you can help here, I can include that now
or in post-review time.

Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/vim-syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/vim-syntastic-3.7.0-4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to