https://bugzilla.redhat.com/show_bug.cgi?id=1372718



--- Comment #18 from Jun Aruga <jar...@redhat.com> ---
(In reply to Vít Ondruch from comment #17)
> (In reply to Jun Aruga from comment #15)
> > - Delete Patch1: rubygem-puma-3.6.0-update-testhelp-path.patch
> > - find test -name '*.rb' -exec sed -i "s|test/testhelp|testhelp|" {} \;
> 
> Well, I said "you can keep it like this" but anyway, since you made the
> changes, then IMO the least effort would be to add both "." as well as
> "test" on the load path and you can avoid the sed line entirely.
> 
> Thanks for opening the upstream discussion though.
> 
> > Could you check this?
> 
> Otherwise the patch looks good.

OK I added "." on the load path, and removed the sed line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to