https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #24 from l...@us.ibm.com ---
(In reply to Tomas Mraz from comment #23)
> I'll review this package.
> 
> My comments:
> 
> Use ExclusiveArch instead of BuildArch and in general follow
> https://fedoraproject.org/wiki/Packaging:
> Guidelines?rd=PackagingGuidelines#Architecture_Support
> If the reason for building on just the architectures specified is that the
> other platforms do not have the hardware needed, then please at least add a
> comment about this fact to the spec.
> 
> The build is nonstandard and does not apply RPM_OPT_FLAGS and LDFLAGS during
> the build which means that hardening and optimalization is not applied. This
> must be fixed too.

Thanks for taking time to review this package!

The developer has been using nonstandard variables such as LNFLAGS (as opposed
to LDFLAGS) and CCFLAGS (for CFLAGS) etc.  There were other compile flags such
as CCLFLAGS for compiling library and CCAFLAGS for compiling application.

Would that be OK to keep the naming of those nonstandard variables, while I'm
making sure that the build includes hardending and optimalization with the
RPM_OPT_FLAGS?



Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to