https://bugzilla.redhat.com/show_bug.cgi?id=1385180



--- Comment #2 from Björn "besser82" Esser <fed...@besser82.io> ---
Thank you for the quick review!  =)

***

Updated package:

Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=16099176


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/purple-facebook.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/purple-facebook-0.0.0.20160409-0.2.git66ee773.fc26.src.rpm

***

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> into pidgin → for pidgin

fixed


> %{__rm} → rm
> There's absolutely no need to do this. The guidelines require macros for
> *directories*, but not for executables. If you have a rogue rm in the path,
> you have bigger problems, and anyway, there are various other programs
> called during build, so guarding just rm isn't useful. Same for %__make.

I think this is more a personal preference of mine and doesn't violate
packaging guidelines.


> - versioning doesn't follow the guidelines
> [https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages
> has the rules, but it's rather muddled unfortunately]. I think keeping the
> git date in version makes sense, but the git tag should be moved to the
> release tag.

fixed

***

Hope the package is fine now and can be approved.  ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to