--- Comment #2 from Björn "besser82" Esser <> ---
Thank you for the quick review!  =)


Updated package:

Koji Build:


  Spec URL:


(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> into pidgin → for pidgin


> %{__rm} → rm
> There's absolutely no need to do this. The guidelines require macros for
> *directories*, but not for executables. If you have a rogue rm in the path,
> you have bigger problems, and anyway, there are various other programs
> called during build, so guarding just rm isn't useful. Same for %__make.

I think this is more a personal preference of mine and doesn't violate
packaging guidelines.

> - versioning doesn't follow the guidelines
> [
> has the rules, but it's rather muddled unfortunately]. I think keeping the
> git date in version makes sense, but the git tag should be moved to the
> release tag.



Hope the package is fine now and can be approved.  ;)

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to

Reply via email to