https://bugzilla.redhat.com/show_bug.cgi?id=1385180

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
(In reply to Björn "besser82" Esser from comment #2)
> > %{__rm} → rm
> > There's absolutely no need to do this. The guidelines require macros for
> > *directories*, but not for executables. If you have a rogue rm in the path,
> > you have bigger problems, and anyway, there are various other programs
> > called during build, so guarding just rm isn't useful. Same for %__make.
> 
> I think this is more a personal preference of mine and doesn't violate
> packaging guidelines.

Yeah, it's just gratuitous obfuscation ;)

OK, the version thing was the only bigger issue. That is fixed now. Package is
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to