https://bugzilla.redhat.com/show_bug.cgi?id=1398433
--- Comment #3 from Dominik 'Rathann' Mierzejewski <[email protected]> --- 1. Why the icons and Requires: hicolor-icon-theme are there in the main package if the demo application and the desktop file are in -devel? Consequently, gtk-update-icon-cache calls should probably be moved to %post* devel, too. 2. Why are you removing these? The changelog entry does not explain. rm -r %{buildroot}/%{_datadir}/locale/bh rm -r %{buildroot}/%{_datadir}/locale/mo 3. There's a changelog entry "- Remove kentauros configuration file.", but I don't see anything apart from the two locales being removed. 4. desktop-file-validate %{buildroot}/%{_datadir}/applications/*.desktop *.desktop could be changed to granite-demo.desktop, since you're explicit in the %files section already. 5. License: LGPLv3, but licensecheck says: $ licensecheck -r . | cut -d: -f2 |sort -u BSD (2 clause) LGPL (v2 or later) (with incorrect FSF address) LGPL (v3 or later) LGPL (v3 or later) (with incorrect FSF address) *No copyright* BSD (3 clause) *No copyright* GENERATED FILE *No copyright* UNKNOWN UNKNOWN So, it should probably be License: LGPLv3+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
