https://bugzilla.redhat.com/show_bug.cgi?id=1398433
--- Comment #5 from Dominik 'Rathann' Mierzejewski <domi...@greysector.net> --- (In reply to Fabio Valentini from comment #4) > 1. The icons are used by GTK+ widgets in the library, not (only) by the demo > application, so they are in the right place (and the scriptlets and > Requires: too). OK. A short comment in the spec file could be useful for future or drive-by maintainers. > 2. rpmlint complains that those 2 languages (bh: Bihari and mo: Moldovian) > are not recognised and looking at the languages fedora supports, they are > not in the list. The reviewer of the old granite package review also wanted > translations for an unsupported language to be removed, so I thought this > was the usual practice. rpmlint is not 100% Fedora Packaging Guidelines compliant (it's cross-distro, after all), so its warnings are to be taken with a grain of salt. I do see both bh and mo directories in /usr/share/locale, so I don't think there's any reason to remove these translations. I'm not sure why rpmlint is saying they're unsupported. Could you post the exact message? > 3. The kentauros configuration file was included as (an unused and purely > informational) Source1 in the older .spec file (remnant from my packaging > scripts). OK. > 4. True. > > 5. It seems so. > > > My questions: > ad 2: Should I keep translations for unsupported languages or remove them? Please keep them. > ad 3: Should I remove the changelog entry? Yes, please. > ad 4: I'll fix that > ad 5: I'll fix that, too Great! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
