https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #30 from gil cattaneo <punto...@libero.it> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'


===== MUST items =====

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
     generated", "*No copyright* Apache (v2.0)". 74 files have unknown
     license. Detailed output of licensecheck in
     /home/gil/1324020-cassandra/licensecheck.txt

 Apache (v2.0) BSD (3 clause)
cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

[!]: License file installed when any subpackage combination is installed.
 Missing NOTICE.txt in javadoc sub package

 The following source files are without license headers:
  cassandra-3.9/doc/source/_static/extra.css

  cassandra-3.9/src/java/org/apache/cassandra/db/commitlog/IntervalSet.java
  cassandra-3.9/src/java/org/apache/cassandra/utils/IntegerInterval.java

 
cassandra-3.9/test/unit/org/apache/cassandra/db/commitlog/CommitLogCQLTest.java
  cassandra-3.9/test/unit/org/apache/cassandra/utils/IntegerIntervalsTest.java

  cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/WorkManager.java
 
cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/util/TimingIntervals.java

 Please, contact upstream and ask to confirm the licensing of code and/or
content/s, and add license headers

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java,
     /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.

[?]: Package contains no bundled libraries without FPC exception.
 cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
 Please, remove: %{?scl:Requires: %scl_require rh-maven33}
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 440320 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[- ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     cassandra-parent , cassandra-thrift , cassandra-clientutil ,
     cassandra-python2-cqlshlib , cassandra-stress , cassandra-javadoc ,
     cassandra-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[!]: Packages are noarch unless they use JNI
     Note: cassandra subpackage is not noarch. Please verify manually

[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 107315200 bytes in /usr/share
     cassandra-javadoc-3.9-1.fc26.i686.rpm:103987200
     See:
    
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: cassandra-3.9-1.fc26.i686.rpm
          cassandra-parent-3.9-1.fc26.i686.rpm
          cassandra-thrift-3.9-1.fc26.i686.rpm
          cassandra-clientutil-3.9-1.fc26.i686.rpm
          cassandra-python2-cqlshlib-3.9-1.fc26.i686.rpm
          cassandra-stress-3.9-1.fc26.i686.rpm
          cassandra-javadoc-3.9-1.fc26.i686.rpm
          cassandra-debuginfo-3.9-1.fc26.i686.rpm
          cassandra-3.9-1.fc26.src.rpm
cassandra.i686: W: name-repeated-in-summary C Cassandra
cassandra.i686: W: spelling-error %description -l en_US repartition -> re
partition, re-partition, reparation
cassandra.i686: E: no-binary
cassandra.i686: E: executable-marked-as-config-file /etc/cassandra-env.sh
cassandra.i686: E: script-without-shebang /etc/cassandra-env.sh
cassandra.i686: E: script-without-shebang /usr/bin/cassandra.in.sh
cassandra.i686: W: non-standard-uid /var/log/cassandra cassandra
cassandra.i686: E: non-standard-dir-perm /var/log/cassandra 750
cassandra.i686: W: non-standard-uid /var/lib/cassandra cassandra
cassandra.i686: W: no-manual-page-for-binary cassandra.in.sh
cassandra.i686: W: no-manual-page-for-binary cassandra
cassandra-parent.i686: W: no-documentation
cassandra-thrift.i686: W: no-documentation
cassandra-clientutil.i686: W: no-documentation
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableutil
cassandra-clientutil.i686: W: no-manual-page-for-binary nodetool
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableupgrade
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablelevelreset
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableexpiredblockers
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablesplit
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablerepairedset
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablemetadata
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableloader
cassandra-clientutil.i686: W: no-manual-page-for-binary sstabledump
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableverify
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablescrub
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableofflinerelevel
cassandra-python2-cqlshlib.i686: W: spelling-error Summary(en_US) Commandline
-> Command line, Command-line, Commandment
cassandra-python2-cqlshlib.i686: W: spelling-error %description -l en_US
Commandline -> Command line, Command-line, Commandment
cassandra-python2-cqlshlib.i686: W: no-manual-page-for-binary cqlsh
cassandra-stress.i686: W: spelling-error %description -l en_US benchmarking ->
bench marking, bench-marking, benchmark
cassandra-stress.i686: W: no-documentation
cassandra-stress.i686: E: script-without-shebang /usr/bin/cassandra.in.sh
cassandra-stress.i686: W: no-manual-page-for-binary cassandra-stressd
cassandra-stress.i686: W: no-manual-page-for-binary cassandra.in.sh
cassandra-stress.i686: W: no-manual-page-for-binary cassandra-stress
cassandra.src: W: name-repeated-in-summary C Cassandra
cassandra.src: W: spelling-error %description -l en_US repartition -> re
partition, re-partition, reparation
cassandra.src:145: W: unversioned-explicit-provides cqlsh
cassandra.src:308: W: mixed-use-of-spaces-and-tabs (spaces: line 308, tab: line
8)
9 packages and 0 specfiles checked; 6 errors, 34 warnings.




Rpmlint (debuginfo)
-------------------
Checking: cassandra-debuginfo-3.9-1.fc26.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
cassandra-python2-cqlshlib.i686: W: spelling-error Summary(en_US) Commandline
-> Command line, Command-line, Commandment
cassandra-python2-cqlshlib.i686: W: spelling-error %description -l en_US
Commandline -> Command line, Command-line, Commandment
cassandra-python2-cqlshlib.i686: W: no-manual-page-for-binary cqlsh
cassandra-thrift.i686: W: no-documentation
cassandra-clientutil.i686: W: no-documentation
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableofflinerelevel
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableloader
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableupgrade
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableexpiredblockers
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablescrub
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableverify
cassandra-clientutil.i686: W: no-manual-page-for-binary sstableutil
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablerepairedset
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablelevelreset
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablesplit
cassandra-clientutil.i686: W: no-manual-page-for-binary nodetool
cassandra-clientutil.i686: W: no-manual-page-for-binary sstablemetadata
cassandra-clientutil.i686: W: no-manual-page-for-binary sstabledump
cassandra-parent.i686: W: no-documentation
cassandra.i686: W: name-repeated-in-summary C Cassandra
cassandra.i686: W: spelling-error %description -l en_US repartition -> re
partition, re-partition, reparation
cassandra.i686: E: no-binary
cassandra.i686: E: executable-marked-as-config-file /etc/cassandra-env.sh
cassandra.i686: E: script-without-shebang /etc/cassandra-env.sh
cassandra.i686: W: non-standard-uid /var/lib/cassandra cassandra
cassandra.i686: W: non-standard-uid /var/log/cassandra cassandra
cassandra.i686: E: non-standard-dir-perm /var/log/cassandra 750
cassandra.i686: E: script-without-shebang /usr/bin/cassandra.in.sh
cassandra.i686: W: no-manual-page-for-binary cassandra.in.sh
cassandra.i686: W: no-manual-page-for-binary cassandra
cassandra-stress.i686: W: spelling-error %description -l en_US benchmarking ->
bench marking, bench-marking, benchmark
cassandra-stress.i686: W: no-documentation
cassandra-stress.i686: E: script-without-shebang /usr/bin/cassandra.in.sh
cassandra-stress.i686: W: no-manual-page-for-binary cassandra.in.sh
cassandra-stress.i686: W: no-manual-page-for-binary cassandra-stress
cassandra-stress.i686: W: no-manual-page-for-binary cassandra-stressd
8 packages and 0 specfiles checked; 6 errors, 30 warnings.



Requires
--------
cassandra-debuginfo (rpmlib, GLIBC filtered):

cassandra-python2-cqlshlib (rpmlib, GLIBC filtered):
    /usr/bin/python
    cassandra
    libc.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    python(abi)
    python-cassandra-driver
    rtld(GNU_HASH)

cassandra-thrift (rpmlib, GLIBC filtered):
    cassandra
    java-headless
    javapackages-tools
    mvn(com.carrotsearch:hppc)
    mvn(com.googlecode.concurrent-trees:concurrent-trees)
    mvn(de.jflex:jflex)
    mvn(org.apache.commons:commons-lang3)
    mvn(org.apache.thrift:libthrift)
    mvn(org.slf4j:jcl-over-slf4j)
    mvn(org.slf4j:log4j-over-slf4j)
    mvn(org.slf4j:slf4j-api)
    mvn(org.tartarus:snowball)

cassandra-clientutil (rpmlib, GLIBC filtered):
    /bin/sh
    cassandra
    java-headless
    javapackages-tools
    mvn(com.google.guava:guava)
    python-cassandra-driver

cassandra-parent (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools

cassandra (rpmlib, GLIBC filtered):
    /bin/sh
    config(cassandra)
    java-headless
    javapackages-tools
    mvn(ch.qos.logback:logback-classic)
    mvn(ch.qos.logback:logback-core)
    mvn(com.addthis.metrics:reporter-config3)
    mvn(com.clearspring.analytics:stream)
    mvn(com.github.ben-manes.caffeine:caffeine)
    mvn(com.github.jbellis:jamm)
    mvn(com.github.stephenc.high-scale-lib:high-scale-lib)
    mvn(com.google.guava:guava)
    mvn(com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru)
    mvn(com.googlecode.json-simple:json-simple)
    mvn(com.ning:compress-lzf)
    mvn(com.thinkaurelius.thrift:thrift-server)
    mvn(commons-cli:commons-cli)
    mvn(commons-codec:commons-codec)
    mvn(io.dropwizard.metrics:metrics-core)
    mvn(io.dropwizard.metrics:metrics-jvm)
    mvn(io.netty:netty-all)
    mvn(joda-time:joda-time)
    mvn(net.java.dev.jna:jna)
    mvn(net.jpountz.lz4:lz4)
    mvn(org.antlr:antlr)
    mvn(org.antlr:antlr-runtime)
    mvn(org.apache.cassandra:cassandra-thrift)
    mvn(org.apache.commons:commons-lang3)
    mvn(org.apache.commons:commons-math3)
    mvn(org.apache.thrift:libthrift)
    mvn(org.caffinitas.ohc:ohc-core)
    mvn(org.codehaus.jackson:jackson-core-asl)
    mvn(org.codehaus.jackson:jackson-mapper-asl)
    mvn(org.eclipse.jdt.core.compiler:ecj)
    mvn(org.fusesource:sigar)
    mvn(org.mindrot:jbcrypt)
    mvn(org.slf4j:jcl-over-slf4j)
    mvn(org.slf4j:log4j-over-slf4j)
    mvn(org.slf4j:slf4j-api)
    mvn(org.xerial.snappy:snappy-java)
    mvn(org.yaml:snakeyaml)
    shadow-utils

cassandra-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools

cassandra-stress (rpmlib, GLIBC filtered):
    /bin/sh
    cassandra



Provides
--------
cassandra-debuginfo:
    cassandra-debuginfo
    cassandra-debuginfo(x86-32)

cassandra-python2-cqlshlib:
    cassandra-python2-cqlshlib
    cassandra-python2-cqlshlib(x86-32)
    cqlsh
    python-cqlshlib
    python-cqlshlib(x86-32)
    python2.7dist(cassandra-pylib)
    python2dist(cassandra-pylib)

cassandra-thrift:
    cassandra-thrift
    cassandra-thrift(x86-32)
    mvn(org.apache.cassandra:cassandra-thrift)
    mvn(org.apache.cassandra:cassandra-thrift:pom:)

cassandra-clientutil:
    cassandra-clientutil
    cassandra-clientutil(x86-32)
    mvn(org.apache.cassandra:cassandra-clientutil)
    mvn(org.apache.cassandra:cassandra-clientutil:pom:)

cassandra-parent:
    cassandra-parent
    cassandra-parent(x86-32)
    mvn(org.apache.cassandra:cassandra-parent:pom:)

cassandra:
    cassandra
    cassandra(x86-32)
    config(cassandra)
    mvn(org.apache.cassandra:cassandra-all)
    mvn(org.apache.cassandra:cassandra-all:pom:)

cassandra-javadoc:
    cassandra-javadoc
    cassandra-javadoc(x86-32)

cassandra-stress:
    cassandra-stress
    cassandra-stress(x86-32)



Unversioned so-files
--------------------
cassandra-python2-cqlshlib:
/usr/lib/python2.7/site-packages/cqlshlib/copyutil.so

Source checksums
----------------
https://github.com/apache/cassandra/archive/cassandra-3.9.tar.gz :
  CHECKSUM(SHA256) this package     :
d9845c1e0f94973d91004c39410c464a24ffc3a3f25a35e6babb5755664cfd49
  CHECKSUM(SHA256) upstream package :
d9845c1e0f94973d91004c39410c464a24ffc3a3f25a35e6babb5755664cfd49
http://central.maven.org/maven2/org/apache/cassandra/cassandra-clientutil/3.9/cassandra-clientutil-3.9.pom
:
  CHECKSUM(SHA256) this package     :
2dfd2c4be0940d40c9d0ec1bc1ee2bcfd79646229bd204923ed063379714960c
  CHECKSUM(SHA256) upstream package :
2dfd2c4be0940d40c9d0ec1bc1ee2bcfd79646229bd204923ed063379714960c
http://central.maven.org/maven2/org/apache/cassandra/cassandra-parent/3.9/cassandra-parent-3.9.pom
:
  CHECKSUM(SHA256) this package     :
65d00a4d73844878ee7ab322b19c561c18200c11d890f71e5b68889592b0becc
  CHECKSUM(SHA256) upstream package :
65d00a4d73844878ee7ab322b19c561c18200c11d890f71e5b68889592b0becc
http://central.maven.org/maven2/org/apache/cassandra/cassandra-all/3.9/cassandra-all-3.9.pom
:
  CHECKSUM(SHA256) this package     :
7b77ee414f2fe19bf0b285a7a81f025780170ce9b5b7d1d259fb39319a532f9a
  CHECKSUM(SHA256) upstream package :
7b77ee414f2fe19bf0b285a7a81f025780170ce9b5b7d1d259fb39319a532f9a
http://central.maven.org/maven2/org/apache/cassandra/cassandra-thrift/3.9/cassandra-thrift-3.9.pom
:
  CHECKSUM(SHA256) this package     :
53fd0a6c44a978b8829a2a058aa36544cf0f99fecdb926c710191e6218b7ff60
  CHECKSUM(SHA256) upstream package :
53fd0a6c44a978b8829a2a058aa36544cf0f99fecdb926c710191e6218b7ff60


Jar and class files in source
-----------------------------
./cassandra-3.9/lib/[stringtemplate4]ST4.jar
./cassandra-3.9/lib/[jsr-305].jar
./cassandra-3.9/lib/[antlr3].jar


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1324020 --plugins Java -m
fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Shell-api, Generic, Java
Disabled plugins: C/C++, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP,
Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to