https://bugzilla.redhat.com/show_bug.cgi?id=1400236

Dhanesh B. Sabane <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Dhanesh B. Sabane <[email protected]> ---
Disclaimer: This is an unofficial review.

* Use the modname macro in the package name too.

* There is no need to declare a separate macro for summary.  Just enter the
summary for the first time and then you can use %{summary} everywhere else. 

* Source0 is incorrect.  It should be 

%{url}/archive/%{version}.tar.gz

* The license associated with the source seems to be ISC only.  I don't
understand why ASL is required here.  

* The description is too terse.  Could you elaborate a bit?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to