https://bugzilla.redhat.com/show_bug.cgi?id=1400236



--- Comment #5 from Dhanesh B. Sabane <[email protected]> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> Not really. The guidelines say that macros should be used for directory
> names [1] (and it's "should", not "must", there are various exceptions) and
> some binaries. Replacing every instance of the package name with a macro
> just makes it harder to copy&paste the text, or to click on a link to open
> it, etc.
> 
> [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

Roger that!

> > python-podcastparser.src: W: invalid-url Source0:
> > https://github.com/gpodder/podcastparser/archive/v0.6.0.tar.gz#/
> 
> Ah, the "v" shouldn't be there. Source0 should be
> %{url}/archive/%{version}.tar.gz#/%{modname}-%{version}.tar.gz

I learned something new today.  I didn't know the part after # allows the
tarball to be renamed.  Thanks for the clarifications. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to