https://bugzilla.redhat.com/show_bug.cgi?id=1402590
Yunying Sun <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Yunying Sun <[email protected]> --- (This is an un-official review from a new packager) 1. > %global _hardened_build Seems _hardened_build is set as default starting from Fedora 23, according to: https://fedoraproject.org/wiki/Changes/Harden_All_Packages Suppose this line can be removed? 2. > Source: > %{url}/releases/download/2016.11.16.1/%{name}.%{version}.tar.xz Use (%version) instead of 2016.11.16.1. 3. > #BuildRequires: gcc > #BuildRequires: gcc-c++ BR for gcc & gcc-c++ would be required according to: http://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B 4. > %setup -qn%{name}.%{version} missing a space before %{name}? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
