https://bugzilla.redhat.com/show_bug.cgi?id=1402590
--- Comment #2 from Raphael Groner <[email protected]> --- (In reply to Yunying Sun from comment #1) > (This is an un-official review from a new packager) > > 1. > > %global _hardened_build > Seems _hardened_build is set as default starting from Fedora 23, according > to: https://fedoraproject.org/wiki/Changes/Harden_All_Packages > Suppose this line can be removed? fedora-review said to need this line. > 2. > > Source: > > %{url}/releases/download/2016.11.16.1/%{name}.%{version}.tar.xz > Use (%version) instead of 2016.11.16.1. OK, but this is no blocker. > 3. > > #BuildRequires: gcc > > #BuildRequires: gcc-c++ > BR for gcc & gcc-c++ would be required according to: > http://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B fedora-review said to remove these lines. cmake (and rpmbuild) depends on gcc anyways. No blocker here, too. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler > 4. > > %setup -qn%{name}.%{version} > missing a space before %{name}? OK, but this is no blocker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
